SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.1.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 37 |
28 |
0 |
0 |
org.woehlke.bloodmoney.BloodMoneyApplication
| Bug |
Category |
Details |
Line |
Priority |
| Class org.woehlke.bloodmoney.BloodMoneyApplication implements same interface as superclass |
STYLE |
RI_REDUNDANT_INTERFACES |
10-19 |
Low |
org.woehlke.bloodmoney.application.BloodMoneyHomeController
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to model in org.woehlke.bloodmoney.application.BloodMoneyHomeController.home(UserSessionBean, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
33 |
Medium |
| Dead store to model in org.woehlke.bloodmoney.application.BloodMoneyHomeController.root(UserSessionBean, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
24 |
Medium |
org.woehlke.bloodmoney.common.FlashMessage
| Bug |
Category |
Details |
Line |
Priority |
| org.woehlke.bloodmoney.common.FlashMessage.getRaised() may expose internal representation by returning FlashMessage.raised |
MALICIOUS_CODE |
EI_EXPOSE_REP |
24 |
Medium |
| new org.woehlke.bloodmoney.common.FlashMessage(String, String, FlashMessageSeverity, Date) may expose internal representation by storing an externally mutable object into FlashMessage.raised |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
13 |
Medium |
| org.woehlke.bloodmoney.common.FlashMessage.setRaised(Date) may expose internal representation by storing an externally mutable object into FlashMessage.raised |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
9 |
Medium |
org.woehlke.bloodmoney.common.FlashMessageSeverity
| Bug |
Category |
Details |
Line |
Priority |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.woehlke.bloodmoney.common.FlashMessageSeverity.value() |
I18N |
DM_CONVERT_CASE |
17 |
Low |
org.woehlke.bloodmoney.config.BloodMoneyProperties
| Bug |
Category |
Details |
Line |
Priority |
| Class org.woehlke.bloodmoney.config.BloodMoneyProperties defines non-transient non-serializable instance field userConfig |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
| Class org.woehlke.bloodmoney.config.BloodMoneyProperties defines non-transient non-serializable instance field webConfig |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
| Class org.woehlke.bloodmoney.config.BloodMoneyProperties defines non-transient non-serializable instance field webSecurity |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
org.woehlke.bloodmoney.config.BloodMoneyProperties$WebConfig
| Bug |
Category |
Details |
Line |
Priority |
| org.woehlke.bloodmoney.config.BloodMoneyProperties$WebConfig.getWebAddResourceHandlers() may expose internal representation by returning BloodMoneyProperties$WebConfig.webAddResourceHandlers |
MALICIOUS_CODE |
EI_EXPOSE_REP |
76 |
Medium |
| org.woehlke.bloodmoney.config.BloodMoneyProperties$WebConfig.getWebAddResourceHandlersStatic() may expose internal representation by returning BloodMoneyProperties$WebConfig.webAddResourceHandlersStatic |
MALICIOUS_CODE |
EI_EXPOSE_REP |
79 |
Medium |
| org.woehlke.bloodmoney.config.BloodMoneyProperties$WebConfig.setWebAddResourceHandlers(String[]) may expose internal representation by storing an externally mutable object into BloodMoneyProperties$WebConfig.webAddResourceHandlers |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
65 |
Medium |
| org.woehlke.bloodmoney.config.BloodMoneyProperties$WebConfig.setWebAddResourceHandlersStatic(String[]) may expose internal representation by storing an externally mutable object into BloodMoneyProperties$WebConfig.webAddResourceHandlersStatic |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
65 |
Medium |
org.woehlke.bloodmoney.config.BloodMoneyProperties$WebSecurity
| Bug |
Category |
Details |
Line |
Priority |
| org.woehlke.bloodmoney.config.BloodMoneyProperties$WebSecurity.getAntMatchersPermitAll() may expose internal representation by returning BloodMoneyProperties$WebSecurity.antMatchersPermitAll |
MALICIOUS_CODE |
EI_EXPOSE_REP |
114 |
Medium |
| org.woehlke.bloodmoney.config.BloodMoneyProperties$WebSecurity.setAntMatchersPermitAll(String[]) may expose internal representation by storing an externally mutable object into BloodMoneyProperties$WebSecurity.antMatchersPermitAll |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
85 |
Medium |
org.woehlke.bloodmoney.measurements.BloodPressureMeasurementController
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to one in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementController.addPost(BloodPressureMeasurementEntity, UserSessionBean, BindingResult, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
104 |
Medium |
| Dead store to one in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementController.editPost(Long, BloodPressureMeasurementEntity, UserSessionBean, BindingResult, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
69 |
Medium |
org.woehlke.bloodmoney.measurements.BloodPressureMeasurementEntity
| Bug |
Category |
Details |
Line |
Priority |
| org.woehlke.bloodmoney.measurements.BloodPressureMeasurementEntity.prepareNew() might ignore java.net.UnknownHostException |
BAD_PRACTICE |
DE_MIGHT_IGNORE |
194 |
Medium |
| org.woehlke.bloodmoney.measurements.BloodPressureMeasurementEntity.prepareUpdated() might ignore java.net.UnknownHostException |
BAD_PRACTICE |
DE_MIGHT_IGNORE |
176 |
Medium |
| Dead store to $L4 in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementEntity.prepareNew() |
STYLE |
DLS_DEAD_LOCAL_STORE |
194 |
Medium |
| Dead store to $L4 in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementEntity.prepareUpdated() |
STYLE |
DLS_DEAD_LOCAL_STORE |
176 |
Medium |
| org.woehlke.bloodmoney.measurements.BloodPressureMeasurementEntity.ZONE_ID__ECT__EUROPE_PARIS isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
153 |
High |
org.woehlke.bloodmoney.measurements.BloodPressureMeasurementResource
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to model in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementResource.add(BloodPressureMeasurementEntity, UriInfo, UserSessionBean, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
116 |
Medium |
| Dead store to model in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementResource.delete(long, UserSessionBean, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
99 |
Medium |
| Dead store to model in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementResource.getOne(BloodPressureMeasurementEntity, UserSessionBean, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
72 |
Medium |
| Dead store to model in org.woehlke.bloodmoney.measurements.BloodPressureMeasurementResource.update(BloodPressureMeasurementEntity, long, UserSessionBean, Model) |
STYLE |
DLS_DEAD_LOCAL_STORE |
87 |
Medium |
org.woehlke.bloodmoney.user.LoginSuccessHandler
| Bug |
Category |
Details |
Line |
Priority |
| Class org.woehlke.bloodmoney.user.LoginSuccessHandler implements same interface as superclass |
STYLE |
RI_REDUNDANT_INTERFACES |
17-44 |
Low |
