The following document contains the results of SpotBugs
SpotBugs Version is 4.1.3
Threshold is medium
Effort is default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 76 | 35 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to frame in new org.woehlke.computer.kurzweil.Mandelbrot2JuliaApplication() | STYLE | DLS_DEAD_LOCAL_STORE | 23 | Medium |
| Dead store to application in org.woehlke.computer.kurzweil.Mandelbrot2JuliaApplication.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 31 | Medium |
| org.woehlke.computer.kurzweil.Mandelbrot2JuliaApplication.main(String[]) needlessly instantiates a class that only supplies static methods | BAD_PRACTICE | ISC_INSTANTIATE_STATIC_CLASS | 31 | Low |
| Usage of GetResource in new org.woehlke.computer.kurzweil.Mandelbrot2JuliaApplication() may be unsafe if class is extended | BAD_PRACTICE | UI_INHERITANCE_UNSAFE_GETRESOURCE | 20 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.woehlke.computer.kurzweil.application.ComputerKurzweilProperties.propertiesFactory(File) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 484 | Medium |
| org.woehlke.computer.kurzweil.application.ComputerKurzweilProperties.propertiesFactory(String, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 502 | Medium |
| Exception is caught when Exception is not thrown in org.woehlke.computer.kurzweil.application.ComputerKurzweilProperties.propertiesFactory(File) | STYLE | REC_CATCH_EXCEPTION | 487 | Low |
| Exception is caught when Exception is not thrown in org.woehlke.computer.kurzweil.application.ComputerKurzweilProperties.propertiesFactory(String, String) | STYLE | REC_CATCH_EXCEPTION | 507 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.application.ComputerKurzweilProperties$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 516 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Confusing to have methods org.woehlke.computer.kurzweil.application.ComputerKurzweilProperties$Allinone$View.getSubtitle() and org.woehlke.computer.kurzweil.tabs.TabType.getSubTitle() | BAD_PRACTICE | NM_CONFUSING | 59 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.woehlke.computer.kurzweil.commons.model.fractal.GaussianNumberPlane.getComplexNumberFromLatticeCoordsForZoomedMandelbrot(Point) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 109-121 | Low |
| Unread field: org.woehlke.computer.kurzweil.commons.model.fractal.GaussianNumberPlane.complexCenterForZoomedMandelbrot | PERFORMANCE | URF_UNREAD_FIELD | 42 | Medium |
| Unread field: org.woehlke.computer.kurzweil.commons.model.fractal.GaussianNumberPlane.complexNumberForJuliaSetC | PERFORMANCE | URF_UNREAD_FIELD | 160 | Medium |
| org.woehlke.computer.kurzweil.commons.model.fractal.GaussianNumberPlane.lattice is a volatile reference to an array; the array elements are non-volatile | MT_CORRECTNESS | VO_VOLATILE_REFERENCE_TO_ARRAY | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.commons.model.turing.MandelbrotTuringMachine$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Increment of volatile field org.woehlke.computer.kurzweil.commons.model.turing.MandelbrotTuringPositions.steps in org.woehlke.computer.kurzweil.commons.model.turing.MandelbrotTuringPositions.goForward() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.commons.model.turing.MandelbrotTuringPositions$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Increment of volatile field org.woehlke.computer.kurzweil.commons.model.turing.Point.y in org.woehlke.computer.kurzweil.commons.model.turing.Point.moveDown() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 42 | Medium |
| Increment of volatile field org.woehlke.computer.kurzweil.commons.model.turing.Point.x in org.woehlke.computer.kurzweil.commons.model.turing.Point.moveLeft() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 46 | Medium |
| Increment of volatile field org.woehlke.computer.kurzweil.commons.model.turing.Point.x in org.woehlke.computer.kurzweil.commons.model.turing.Point.moveRight() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 38 | Medium |
| Increment of volatile field org.woehlke.computer.kurzweil.commons.model.turing.Point.y in org.woehlke.computer.kurzweil.commons.model.turing.Point.moveUp() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaCanvas defines non-transient non-serializable instance field app | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L2 in org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaController.run() | STYLE | DLS_DEAD_LOCAL_STORE | 38 | Medium |
| Synchronization on Boolean in org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaController.exit() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 44 | High |
| Synchronization on Boolean in org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaController.run() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 31 | High |
| Synchronization on Mandelbrot2JuliaController.goOn in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 45 | Medium |
| Class org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaController implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 18-47 | Low |
| Unread field: org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaController.THREAD_SLEEP_TIME; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 18 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaModel$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to separator in new org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaTab(ComputerKurzweilProperties) | STYLE | DLS_DEAD_LOCAL_STORE | 43 | Medium |
| Class org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaTab implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 36-142 | Low |
| new org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaTab(ComputerKurzweilProperties) invokes org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaController.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 52 | Low |
| Class org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaTab defines non-transient non-serializable instance field mandelbrotController | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.Mandelbrot2JuliaTab defines non-transient non-serializable instance field mandelbrotModel | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.tabs.mandelbrot2julia.model.Mandelbrot2JuliaStateMachine$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 24 | Medium |