The following document contains the results of SpotBugs
SpotBugs Version is 4.1.3
Threshold is medium
Effort is default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 25 | 25 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to frame in new org.woehlke.computer.kurzweil.mandelbrot.MandelbrotSetApplication() | STYLE | DLS_DEAD_LOCAL_STORE | 17 | Medium |
| Dead store to application in org.woehlke.computer.kurzweil.mandelbrot.MandelbrotSetApplication.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 25 | Medium |
| org.woehlke.computer.kurzweil.mandelbrot.MandelbrotSetApplication.main(String[]) needlessly instantiates a class that only supplies static methods | BAD_PRACTICE | ISC_INSTANTIATE_STATIC_CLASS | 25 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L2 in org.woehlke.computer.kurzweil.mandelbrot.control.ControllerThread.run() | STYLE | DLS_DEAD_LOCAL_STORE | 41 | Medium |
| Synchronization on Boolean in org.woehlke.computer.kurzweil.mandelbrot.control.ControllerThread.exit() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 47 | High |
| Synchronization on Boolean in org.woehlke.computer.kurzweil.mandelbrot.control.ControllerThread.run() | MT_CORRECTNESS | DL_SYNCHRONIZATION_ON_BOOLEAN | 34 | High |
| Synchronization on ControllerThread.goOn in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 48 | Medium |
| Class org.woehlke.computer.kurzweil.mandelbrot.control.ControllerThread implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 21-50 | Low |
| Unread field: org.woehlke.computer.kurzweil.mandelbrot.control.ControllerThread.THREAD_SLEEP_TIME; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 21 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.mandelbrot.model.ApplicationModel$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.woehlke.computer.kurzweil.mandelbrot.model.fractal.GaussianNumberPlane.lattice is a volatile reference to an array; the array elements are non-volatile | MT_CORRECTNESS | VO_VOLATILE_REFERENCE_TO_ARRAY | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Increment of volatile field org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.y in org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.moveDown() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 42 | Medium |
| Increment of volatile field org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.x in org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.moveLeft() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 46 | Medium |
| Increment of volatile field org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.x in org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.moveRight() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 38 | Medium |
| Increment of volatile field org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.y in org.woehlke.computer.kurzweil.mandelbrot.model.helper.Point.moveUp() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.mandelbrot.model.state.ApplicationStateMachine$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 25 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.mandelbrot.model.turing.MandelbrotTuringMachine$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 37 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Increment of volatile field org.woehlke.computer.kurzweil.mandelbrot.model.turing.TuringPositions.steps in org.woehlke.computer.kurzweil.mandelbrot.model.turing.TuringPositions.goForward() | MT_CORRECTNESS | VO_VOLATILE_INCREMENT | 45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to $L0 in org.woehlke.computer.kurzweil.mandelbrot.model.turing.TuringPositions$1.<static initializer for 1>() | STYLE | DLS_DEAD_LOCAL_STORE | 46 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.woehlke.computer.kurzweil.mandelbrot.view.ApplicationCanvas defines non-transient non-serializable instance field app | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.woehlke.computer.kurzweil.mandelbrot.view.ApplicationFrame implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 36-144 | Low |
| new org.woehlke.computer.kurzweil.mandelbrot.view.ApplicationFrame(Config) invokes org.woehlke.computer.kurzweil.mandelbrot.control.ControllerThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 55 | Low |
| Class org.woehlke.computer.kurzweil.mandelbrot.view.ApplicationFrame defines non-transient non-serializable instance field applicationModel | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.woehlke.computer.kurzweil.mandelbrot.view.ApplicationFrame defines non-transient non-serializable instance field controllerThread | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.woehlke.computer.kurzweil.mandelbrot.view.PanelButtons defines non-transient non-serializable instance field model | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |